Changes to FastaReferenceWriter #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==============================================
+ Coverage 67.49% 67.496% +0.006%
Complexity 8150 8150
==============================================
Files 558 558
Lines 33365 33365
Branches 5608 5608
==============================================
+ Hits 22518 22520 +2
+ Misses 8658 8657 -1
+ Partials 2189 2188 -1
|
yfarjoun
reviewed
Feb 16, 2019
* HttpUtilsTest is flakey because it connects to remote web servers. Moved it to the testExternalAPIs test task * changed a broken link so that the tests pass again
lbergelson
force-pushed
the
lb_fasta_writer_fixes
branch
from
73cef64
to
d2aa174
Compare
* make sure the OutputStreams are always buffered * change close behavior to be more likely to close all output streams in the event of an early shutdown * loosen restriction from BufferedWriter to Writer in SAMSequenceDictionaryCodec and SAMTextHeaderCodec
yfarjoun
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the event of an early shutdown
SAMSequenceDictionaryCodec and SAMTextHeaderCodec